-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include warning in get_datalabs_path method for ehst when the data volume is not mounted in DataLabs #3059
Include warning in get_datalabs_path method for ehst when the data volume is not mounted in DataLabs #3059
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to do what the description says but interacts with the users' local paths.
Dear @bsipocz , let me explain the purpose of this method. The point is that they should mount the volume before. If that is not the case, the file will not be accessible. So, we have modified the method in case this happens, so we can warn the user that he/she should mount the volume before using that path. It has no sense to use this method outside ESA Datalabs, as the file is not available in the user's local environment, but it is in Datalabs. E.g. another application we have. The user can now download a Jupyter Notebook with a search and commands to download files from our UI and open it into Datalabs automatically. With this method, they can retrieve the files from the volume instead of downloading them. |
Please let us know if we should show more clearly the purpose of this method. |
This seems to be an unrelated issue. Please let us know if everything is ok, thanks @bsipocz ! |
I'm going ahead and rebase this to get rid of the merge commit and to hope the CI got just fixed, too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, content wise this looks good. We have unrelated CI issues, and also the ESA servers seems to be down atm, but that shouldn't affect this anyway.
1594eaa
to
f1890ac
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3059 +/- ##
==========================================
- Coverage 67.55% 67.54% -0.02%
==========================================
Files 233 233
Lines 18289 18320 +31
==========================================
+ Hits 12356 12375 +19
- Misses 5933 5945 +12 ☔ View full report in Codecov by Sentry. |
…lume is not mounted in DataLabs
Align to PEP8
f1890ac
to
0b6a016
Compare
Thanks @davidglt! |
Yes, we had a hardware maintenance window yesterday, but ESA modules should be working today. |
Include warning in get_datalabs_path method for ehst when the data volume is not mounted in DataLabs