Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include warning in get_datalabs_path method for ehst when the data volume is not mounted in DataLabs #3059

Merged

Conversation

davidglt
Copy link
Contributor

@davidglt davidglt commented Jul 1, 2024

Include warning in get_datalabs_path method for ehst when the data volume is not mounted in DataLabs

@pep8speaks
Copy link

pep8speaks commented Jul 1, 2024

Hello @davidglt! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-07-08 23:03:54 UTC

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to do what the description says but interacts with the users' local paths.

astroquery/esa/hubble/core.py Show resolved Hide resolved
astroquery/esa/hubble/core.py Outdated Show resolved Hide resolved
@jespinosaar
Copy link
Contributor

Dear @bsipocz , let me explain the purpose of this method.
Maybe you don't know, but we are developing ESA Datalabs, a science portal where users will be able to access their data using a Datalabs which, in the end, is a docker image, accesible via web interface, where users can mount the volumes associated to our data in read mode. This means, they don't have to download the data to use it. They can simply mount the volume and retrieve the appropriate file. Therefore, the purpose of this method is to add a very easy way, using our astroquery module, to retrieve the path of the file.

The point is that they should mount the volume before. If that is not the case, the file will not be accessible. So, we have modified the method in case this happens, so we can warn the user that he/she should mount the volume before using that path. It has no sense to use this method outside ESA Datalabs, as the file is not available in the user's local environment, but it is in Datalabs.

E.g. another application we have. The user can now download a Jupyter Notebook with a search and commands to download files from our UI and open it into Datalabs automatically. With this method, they can retrieve the files from the volume instead of downloading them.

@jespinosaar
Copy link
Contributor

Please let us know if we should show more clearly the purpose of this method.

@jespinosaar
Copy link
Contributor

This seems to be an unrelated issue. Please let us know if everything is ok, thanks @bsipocz !

@bsipocz
Copy link
Member

bsipocz commented Jul 8, 2024

I'm going ahead and rebase this to get rid of the merge commit and to hope the CI got just fixed, too.

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, content wise this looks good. We have unrelated CI issues, and also the ESA servers seems to be down atm, but that shouldn't affect this anyway.

@bsipocz bsipocz force-pushed the ESA_ehst_show_warning_no_volume branch from 1594eaa to f1890ac Compare July 8, 2024 22:26
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 67.54%. Comparing base (5d42c1f) to head (f1890ac).
Report is 14 commits behind head on main.

Files Patch % Lines
astroquery/esa/hubble/core.py 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3059      +/-   ##
==========================================
- Coverage   67.55%   67.54%   -0.02%     
==========================================
  Files         233      233              
  Lines       18289    18320      +31     
==========================================
+ Hits        12356    12375      +19     
- Misses       5933     5945      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bsipocz bsipocz force-pushed the ESA_ehst_show_warning_no_volume branch from f1890ac to 0b6a016 Compare July 8, 2024 23:03
@bsipocz bsipocz merged commit d78af7b into astropy:main Jul 8, 2024
8 checks passed
@bsipocz
Copy link
Member

bsipocz commented Jul 8, 2024

Thanks @davidglt!

@jespinosaar
Copy link
Contributor

OK, content wise this looks good. We have unrelated CI issues, and also the ESA servers seems to be down atm, but that shouldn't affect this anyway.

Yes, we had a hardware maintenance window yesterday, but ESA modules should be working today.
Many thanks for your support @bsipocz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants